Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Solax X1] RTS support and offline status #14305

Merged
merged 8 commits into from
Jan 7, 2022
Merged

[Solax X1] RTS support and offline status #14305

merged 8 commits into from
Jan 7, 2022

Conversation

SteWers
Copy link
Contributor

@SteWers SteWers commented Jan 6, 2022

Description:

  • Added support for RS485-boards wich need a seperate RTS-line, when sending data
  • Added status "off", when there is no response form the inverter

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.4.9
  • The code change is tested and works with Tasmota core ESP32 V.2.0.2
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

s-hadinger
s-hadinger reviewed Jan 6, 2022
View reviewed changes
tasmota/tasmota_template_legacy.h Outdated Show resolved Hide resolved
tasmota/tasmota_template_legacy.h Outdated Show resolved Hide resolved
@SteWers
Rework for PR arendst#14305
d88110e 
- removed all changes in tasmota_template_legacy.h
- moved new GPIO at the end of the list in  tasmota_template.h
- removed unnecessary "flush" in xnrg_12_solaxX1.ino
@SteWers
Copy link
Contributor Author

SteWers commented Jan 6, 2022

Thanks for your comments. I've implemented your suggestions.

@arendst arendst merged commit 79bcdd0 into arendst:development Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arendst arendst arendst left review comments

@s-hadinger s-hadinger s-hadinger left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SteWers @arendst @s-hadinger