Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Berry stores compiled bytecode into IRAM, freeing space in heap #14307

Merged
merged 1 commit into from
Jan 6, 2022

Conversation

s-hadinger
Copy link
Collaborator

Description:

Enabled by default with #define USE_BERRY_IRAM, when no PSRAM is present, compiled Berry bytecode is moved into IRAM rather than DRAM. This allows us to use the ~40KB of untapped IRAM (IRAM needs reads/writes to be 32 bits aligned which does not make it suitable for any use).

No impact on speed.

Note: only ktab (list of constants), blineinfo (line numbers for debug) and code (actual bytecode) are move to IRAM, which makes typically 30%-40% of memory used by custom code.

Note2: when using #define USE_BERRY_DEBUG, the line number information has its size slightly increased, but can be moved to IRAM, so that's a positive net benefit.

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.4.9
  • The code change is tested and works with Tasmota core ESP32 V.2.0.2
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@s-hadinger s-hadinger merged commit 1e6b78a into arendst:development Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant