-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add favicon on browser #14322
Add favicon on browser #14322
Conversation
Thx. As the icon is actually black and white do you see a chance to lower it's color depth from 16 gray scale to 1 gray scale? I don't use compression so for me it adds 400+ bytes bogus information. |
Awesome! |
Black and white would make it ugly since there would be no dithering. |
I love #ifdef. |
Hi @arendst I added |
Thx. Will chk today |
i do it this way: in xdrv_01_webserver.ino i add at "const char HTTP_HEAD_STYLE3[]" following </style>""" & vblf & " """"" & vblf & vblf |
Description:
Related issue (if applicable): fixes #4830
Add a favicon directly encoded in base64 in the HTML header (not served through the webserver)
May be not the most pretty tasmo'art but compact (16x16, 16 grey levels).
Only cost 256 bytes of flash due to unishox compression (馃檹 @s-hadinger )
Needed a small change in html compression tool to support string with
//
inside. => @s-hadinger(replaced the split() with a simple state-machine parser)
@gemu2015 could you please check that I've not broken SCRIPT_FULL_WEBPAGE please ?
Checklist:
NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass