Downsizing JavaScript #15280
Merged
Downsizing JavaScript #15280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replacing anonymous functions by arrow functions saves 40 Bytes of JavaScript code.
99999999 and 1e8 are not the same number, but srollTop only needs to be very large, not that particular number. saves 18 Bytes of JavaScript code.
|
Thx. I just remembered these lambda functions failed on IE and I even have a define for them: USE_JAVASCRIPT_ES6 I see it's disabled in For now thx for the effort. I need to decide if I want to go all-in on lambda functions. |
|
I love it. Nice work. I don't think it's a big deal to lose IE compatibility. |
|
100% agree to drop IE support. Microsoft has done too. |
arendst
added a commit
that referenced
this pull request
Apr 3, 2022
Remove support for Internet Explorer by allowing ECMAScript6 syntax using less JavaScript code bytes (#15280)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Using lambdas (arrow functions) and using scientific notation for large integers we can save 58 Bytes of JavaScript code.
Not sure it is really worth a lot, but for fun I provide this PR 馃槈
Checklist: