Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the ca_AD ( catalan ) Translation #16145

Merged
merged 8 commits into from Aug 6, 2022

Conversation

HardwareBoffin
Copy link

@HardwareBoffin HardwareBoffin commented Aug 3, 2022

Description:

Related issue (if applicable): fixes #

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.4.9
  • The code change is tested and works with Tasmota core ESP32 V.2.0.4.1
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

Removed official tasmota logo, added repo intention.
Work in progress for testing integration
Just added that commented config option. I tested it works beforehand.
@HardwareBoffin
Copy link
Author

Just added the ca_AD.h file and updated the user config to add the commented option.

Copy link
Contributor

@ascillato ascillato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, do not change the README.md file.

README.md Outdated Show resolved Hide resolved
@s-hadinger
Copy link
Collaborator

It's also missing the build definitions in platform_tadmota_env[32].ini

@HardwareBoffin
Copy link
Author

platform_tasmota_env[32].ini modified as requested.

@Jason2866
Copy link
Collaborator

Where are the changes? Readme still changed and platformioxxx.ini file still missing

@arendst arendst merged commit 15a1bba into arendst:development Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants