Enable more than two and up to four BMP/BME sensors on two I2C buses … #17643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for ESP32 (only two addresses (76, 77) per I2C bus are possible). (enhancement of arendst#10827,arendst#1049, arendst#2707)
arendst
added a commit
that referenced
this pull request
Jan 8, 2023
Add ESP32 support for BMPxxx sensors on two I2C busses (#17643)
Maschotta
added a commit
to Maschotta/Tasmota
that referenced
this pull request
Jan 9, 2023
arendst
pushed a commit
that referenced
this pull request
Jan 10, 2023
|
It seems that this change causes problems when only one sensor is connected. I flashed an ESP32 with the latest build and with one BME280 sensor, I get this sensor displayed twice. |
|
I'm also seeing that issue. Also looks like a breaking change when the address is included in the sensor name, instead of only when there's more than one address. Same error in the JSON, which for practical purposes is invalid JSON. |
|
Let's see if I can spend my sunday afternoon in fixing this.... |
Maschotta
added a commit
to Maschotta/Tasmota
that referenced
this pull request
Jan 15, 2023
Maschotta
added a commit
to Maschotta/Tasmota
that referenced
this pull request
Jan 15, 2023
arendst
added a commit
that referenced
this pull request
Jan 15, 2023
Fix BMP support on two busses (#17643)
|
Fixed. |
Maschotta
added a commit
to Maschotta/Tasmota
that referenced
this pull request
Jan 15, 2023
…ensor recognition if one bus is used. I2cSetDevice uses bus 0 as default, even if there is no second I2C bus. Hence, sensors are recognized twice.
Maschotta
added a commit
to Maschotta/Tasmota
that referenced
this pull request
Jan 15, 2023
Maschotta
added a commit
to Maschotta/Tasmota
that referenced
this pull request
Jan 15, 2023
…ensor recognition if one bus is used. I2cSetDevice uses bus 0 as default, even if there is no second I2C bus. Hence, sensors are recognized twice.
Maschotta
added a commit
to Maschotta/Tasmota
that referenced
this pull request
Jan 15, 2023
Maschotta
pushed a commit
to Maschotta/Tasmota
that referenced
this pull request
Jan 15, 2023
Fix BMP support on two busses (arendst#17643)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…for ESP32 (only two addresses (76, 77) per I2C bus are possible). (enhancement of #10827,#1049, #2707)
It is now possible to use four BMP/BME sensors with one ESP32. It is necessary to use two I2C buses because there are only two possible I2C addresses for BMP/BME.
Description:
Related issue (if applicable): fixes #
Checklist:
NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass