-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Sensirion SEN5X lib + I2C driver #17736
Conversation
I haven't got an esp8266 for testing. |
Where is the Tasmota driver? This PR provides only the Sensirion lib. |
Sorry, my mistake, I squashed it out of existence. Will fix when I get home
…On Wed, 18 Jan 2023, 08:50 Jason2866, ***@***.***> wrote:
Where is the Tasmota driver? This PR provides only the Sensirion lib.
—
Reply to this email directly, view it on GitHub
<#17736 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABTBZ43ATOJQL4HOZUN2EF3WS6VHFANCNFSM6AAAAAAT6MRC7M>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
def690e
to
b61a9ea
Compare
Please undo the password SSID changes in my_user_config.h |
ccea21e
to
3f9f6bd
Compare
I2C address clashes leading to faulty detection is not too unusual, and it is commonly recommended for the user to mitigate such issues by using the command |
@tyeth As sfromis explained the current driver regarding i2c handling is okay. |
a8cf646
to
314c92c
Compare
I've made significant improvements, especially around logging, more thorough testing in situ, and error handling depending on sensor model (no VOC/NOx/Temp/Hum with SEN50 - only particules, SEN54 missing only VOC, sen55 full features). It's also been thoroughly tested on both I2C busses with other sensors attached. I must confess my sins, it was poorly tested and actually broken when first submitted so lessons learned and my apologies. I had problems building firmwares with all needed features, using tasmocompiler seemed to be okay, but my custom builds always showed max or min values for all sensors. I was trying to do too much at once as most newbies do - requiring display/lvgl/custom-defines, especially stumbled with certain unexpected defines like the AHT1x when I'm using the AHT20, they conflict and the docs says AHT1x isn't included in default builds but it is... Happy enough now once the SPS30 pull request is merged. They can be merged separately but would be grateful if they made it into the next release together. |
Sorry, forgot there were missing units. Will fix immediately. |
Please remove the sps30 driver changes from this PR. The SPS30 PR will be merged together or before this PR ;-) |
Ah sorry, slipped back in with the units ;) |
dd63823
to
6809698
Compare
Seen the failure, I'll add a guard around wire1 for esp32, falling back to wire if necessary. |
- ESP32 support for eigth energy phases/channels - ESP32 command ``EnergyCols 1..8`` to change number of GUI columns - ESP32 command ``EnergyDisplay 1..3`` to change GUI column presentation - support for SEN5X gas and air quality sensor by Tyeth Gundry (#17736)
Description:
Adds SEN5x series of Particulate sensors (1-10PPM/Temp/Humidity/NOx/VOC)
also SEN54 (voc+ppm+temp+humidity) or SEN50 (PPM only)
see https://sensirion.com/products/catalog/SEN55/ etc
Checklist:
NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass