Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Berry string.format() now automatically converts type according to format #18890

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

s-hadinger
Copy link
Collaborator

Description:

Applying upstream PRs:

string.format() now automatically tries to convert to int/real/string according to the format:

  • if %d/i/o/u/x/X/c, an explicit call to int() is made to convert to int
  • if %e/E/f/g/G, an explicit call to real() is made
  • if %s an explicit call to str() is made
# Example:

string.format("%i", "3")  # now return '3' instead of ''

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.4.9
  • The code change is tested and works with Tasmota core ESP32 V.2.0.10
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@s-hadinger s-hadinger merged commit 3fc932d into arendst:development Jun 16, 2023
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant