Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Matter Flow sensor support #19852

Merged
merged 14 commits into from Nov 3, 2023
Merged

Conversation

lboue
Copy link
Contributor

@lboue lboue commented Oct 27, 2023

Description:

Adding Matter Flow sensor support: A Flow Sensor device measures and reports the flow rate of a fluid.

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.4.9
  • The code change is tested and works with Tasmota core ESP32 V.2.0.14
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@lboue
Copy link
Contributor Author

lboue commented Nov 1, 2023

Hello,

I've set up a counter on my device.

tasmota.read_sensors()
{"Time":"2023-11-01T14:07:47","Switch6":"ON","COUNTER":{"C2":20}}

I would like Tasmota to return the numerical value of this counter for my Matter flow sensor to validate that it is working correctly. What should I set for 'Filter pattern'?

image

@@ -448,7 +451,10 @@ module matter (scope: global, strings: weak) {
Plugin_ShutterTilt, class(be_class_Matter_Plugin_ShutterTilt) // Shutter + Tilt
Plugin_Sensor, class(be_class_Matter_Plugin_Sensor) // Generic Sensor
Plugin_Sensor_Pressure, class(be_class_Matter_Plugin_Sensor_Pressure) // Pressure Sensor
Plugin_Sensor_Flow, class(be_class_Matter_Plugin_Sensor_Flow) // Flow Sensor
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plugin_Sensor_Flow seems to be declared twice

@s-hadinger
Copy link
Collaborator

Awesome job!

@s-hadinger s-hadinger merged commit 8c40d77 into arendst:development Nov 3, 2023
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants