Webcam v2 tweaks 2024 #20451
Merged
Webcam v2 tweaks 2024 #20451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stop the actual cam clock.
… 0/1 to be more TAS like, and save a little.
hawa-lc4
pushed a commit
to hawa-lc4/Tasmota-dev
that referenced
this pull request
Jan 20, 2024
* suppress compiler warning about 'used' function * don't stop and start cam webserver every time we save to flash. Only stop the actual cam clock. * change cmds WcMenuVideoon and wcmenuvideooff to be wcmenuvideodisable 0/1 to be more TAS like, and save a little.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Minor updates to fix enable/disable video on main menu.
This is in the webcamv2 driver only.
Previously, every time flash was saved, it would stop and restart the video webserver port.
This PR disables that, so that on flash/SD action, it only stops and then starts the cam itself, which I believe was the orginal intent.
The bug was that on enable/disable of menu video, a flash save occurred. Sometimes, the browser would have connected to the video webserver port before it was then disabled/removed - and so the menu video would stop.
It also changes the command used by the menu item 'Turn On Video'/'Turn Off Video' to be called wcMenuVideoDisable, and uses 0/1 parameter, so making the command much more 'TAS' like. since this command was only used by the menu, it's little risk to change,
These are minor changes and are as a result of testing with arduino V3.
I can report basic operation of webcam v2 with esp32 and esp32s3 is ok. (the bug this PR relates to is NOT related to arduino v3).
Checklist:
NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass