Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added RelayLock to Lock specific relays from beeing changed #21081

Closed
wants to merge 11 commits into from

Conversation

stefanbode
Copy link
Contributor

@stefanbode stefanbode commented Apr 1, 2024

Description:

Sometimes it might be useful and required to LOCK a relay e.g. to temporary disconnect ALEXA or other smart home from changing a relay. The new command relaylock<x> 1|0 can disable or enable a lock on a specific relay

  • interlock still works - higher priority
  • running pulsetimers will NOT change after timeout if relaylock set during timer
  • shutters gets confused if relay does not switch. Anyhow Shutterlock exist. Therefore acceptable issue

Related issue (if applicable): fixes #

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.6
  • The code change is tested and works with Tasmota core ESP32 V.2.0.14
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@arendst
Copy link
Owner

arendst commented Apr 3, 2024

Thx for the code. I won't merge this PR as it is. I see a better location in the Settings area and I want to rename the command from RelayLock to PowerLock as it also works on display power and lights.

I will implement this my way.

BTW did you test what happens with bi-stable relays (using two bits within the power uint32_t)?

@arendst arendst added the on hold by dev team Result - Feature request put on hold by member of development team label Apr 3, 2024
@arendst arendst self-assigned this Apr 3, 2024
@stefanbode
Copy link
Contributor Author

Thx for the code. I won't merge this PR as it is. I see a better location in the Settings area and I want to rename the command from RelayLock to PowerLock as it also works on display power and lights.

I will implement this my way.

BTW did you test what happens with bi-stable relays (using two bits within the power uint32_t)?

Hi Theo, "RelayLock" was a hallucination of ChatGPT how to do it. Therefore I assumed this might be most straight forward. Anyhow PowerLock is also fine. In this case ChatGPT has to learn it :-)

Bi-Stable relays is new to me. Never seen this. I will read the doc and test it with the current implementation. Thx.

arendst added a commit that referenced this pull request Apr 3, 2024
- Add command ``PowerLock`` to disable power control of selected outputs (#21081)
@arendst
Copy link
Owner

arendst commented Apr 3, 2024

Functionality implemented as command PowerLock.

@arendst arendst closed this Apr 3, 2024
@arendst
Copy link
Owner

arendst commented Apr 3, 2024

Regarding the bi-stable relay it seems to work fine too.

So let's see what users come up with.

Thx for the idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on hold by dev team Result - Feature request put on hold by member of development team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants