Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Berry math.inf, math.isinf() and fixed json ouput for inf and nan #21304

Merged
merged 1 commit into from Apr 29, 2024

Conversation

s-hadinger
Copy link
Collaborator

Description:

Berry anticipation of berry-lang/berry#421

Add support for math.inf representing the normalized Infinity:

  • math.inf is infinity (positive), can be set as negative with -math.inf
  • math.isinf() to test if a value is infinity

For json.dump, values inf, -inf and nan now convert to null which is the best match since inf and nan are not valid json values.

Related issue (if applicable): fixes #21296

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.6
  • The code change is tested and works with Tasmota core ESP32 V.3.0.0
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@s-hadinger s-hadinger merged commit fd148a8 into arendst:development Apr 29, 2024
59 checks passed
hawa-lc4 pushed a commit to hawa-lc4/Tasmota-dev that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Berry energy.read outputs invalid JSON (nan issue)
1 participant