Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed void unwanted OTA upgrade when safeboot starts for the first time #21360

Merged

Conversation

s-hadinger
Copy link
Collaborator

Description:

When booting the first time on safeboot partition, an unwanted OTA upgrade from OtaURL would automatically be triggered. This is due to NvmLoad("otal", "otal", &pOtaLoader, sizeof(pOtaLoader)); not updating pOtaLoader since the value does not yet exist in NMV, hence the value would default to a random value from the stack, and generally not 0.

This PR sets the default value to 0 so no unwanted OTA is done when NVM is not yet populated.

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.6
  • The code change is tested and works with Tasmota core ESP32 V.3.0.0
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@s-hadinger s-hadinger merged commit 3d0532c into arendst:development May 5, 2024
59 checks passed
hawa-lc4 pushed a commit to hawa-lc4/Tasmota-dev that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant