Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollershutters: Configurable pause between change of direction of a moving rollershutter #7133

Closed
wbuh123 opened this issue Dec 7, 2019 · 7 comments
Labels
requested feature (hold over) Result - Feature that will not be added soon (out of scope) workaround Result - The work on the issue has ended with an alternative solution

Comments

@wbuh123
Copy link

wbuh123 commented Dec 7, 2019

Dear dev-team of the rollershutter feature in tasmota,
this is a feature request:
it would be very nice to get an option to set a duration in seconds for a pause in case the user wants to change the direction of a moving rollershutter.
If you have heavy rollershutters and it is moving already and the operator wants to change the direction it's better to first stop the movement of the rollershutter, pause a configurable duration and afterwards move into the new direction.

Do you see a chance to implement this?
Yours sincerly
wbuh

@ascillato2 ascillato2 added the feature request (devs?) Action - awaiting response from developers label Dec 7, 2019
@stefanbode
Copy link
Contributor

This is already implemented but hard coden with 500ms. You need to change in the source code the variable Shutter_motor_delay from 500 to more if you need. If you find a situation where it does not work please report here

@ascillato2 ascillato2 added requested feature (hold over) Result - Feature that will not be added soon (out of scope) workaround Result - The work on the issue has ended with an alternative solution and removed feature request (devs?) Action - awaiting response from developers labels Dec 17, 2019
@ascillato2
Copy link
Collaborator

Closing this issue as it has been answered.


Support Information (Guide)

See Wiki for more information.
See FAQ for common questions/answers and links if none of your question is in the list.
See Chat for more user experience.
See Community for forum.
See Code of Conduct

@wbuh123
Copy link
Author

wbuh123 commented Jan 6, 2020

Dear @stefanbode,
thank you for your quick replay.
Unfortunately I'm not able to find the file with Shutter_motor_delay in the repository?
Thank you for any hint.
wbuh

@wbuh123
Copy link
Author

wbuh123 commented Feb 16, 2020

This is already implemented but hard coden with 500ms. You need to change in the source code the variable Shutter_motor_delay from 500 to more if you need. If you find a situation where it does not work please report here

I can't find "Shutter_motor_delay". What's the file of this variable?
There is a MOTOR_STOP_TIME in xdrv_27_shutter.ino but I don't think it's the same?

@taste66
Copy link

taste66 commented Feb 16, 2020

Looks like it is MOTOR_STOP_TIME
const uint16_t MOTOR_STOP_TIME = 500; // in mS

See function:

void ShutterDelayForMotorStop(void)
{
  AddLog_P2(LOG_LEVEL_INFO, PSTR("SHT: Wait for Motorstop %d"), MOTOR_STOP_TIME);
  delay(MOTOR_STOP_TIME);
}

@stefanbode
Copy link
Contributor

Yes this was implemented to give the motor a small pause before changing directions. The main cause was just to ensure to prevent abrupt changes. Therefore this was hardcoded because there is normally no need to have it flexible.

@taste66
Copy link

taste66 commented Feb 16, 2020

Yes this was implemented to give the motor a small pause before changing directions.

@stefanbode Thank you for this explanation. Turns-out my problem reported in #216 what not caused by a too short delay but by the fact the processor is really waiting and does not executed other tasks. Any hints how I could fix this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requested feature (hold over) Result - Feature that will not be added soon (out of scope) workaround Result - The work on the issue has ended with an alternative solution
Projects
None yet
Development

No branches or pull requests

4 participants