Attributes are not added to node if it already exists but has no attributes

[rpolley]

I was trying to use this to edit some xml based config files, but I ran into an issue: consider the following xml file somefile.xml

<config>
  <setting>
</config>

And the following manifest

xml_fragment { 'set setting.value to 1` :
  ensure => 'present'
  path => 'somefile.xml',
  xpath => '/config/setting',
  content => {
    attributes => {
      value => 1
    }
  }

Will result in an unchanged somefile.xml, however if the somefile.xml file was instead:

<config>
  <setting value=2>
</config>

You would instead end up with

<config>
  <setting value=1>
</config>

This is of course a simplified example, but it causes bugs when you try to use this to edit IIS config files, which use the convention of having attributes represent leaf settings that can be assigned values and the absence of a given attribute means that the setting the attribute represents takes its default value.

[rpolley]

I believe this is caused by

xml_fragment/lib/puppet/provider/xml_fragment/xml_fragment.rb

Line 188 in f9873c8

next unless should.key?('attributes') && i.key?('attributes')

which causes the provider matches method to not compare the should value for the attributes to the is value of the attributes if the is value is nil, which is the case if the tag exists but does not have attributes

[Areson]

I will try and review this in the next week.

[Areson]

@rpolley You were spot on. Adding a check for the case where the definition has attributes defined but the existing element doesn't have any. Tested it on my end and it appears to work, but go ahead and pull from the development branch and give if a go before I package it up.

[Areson]

@rpolley Bump

[1WindowsPuppetAdmin]

@Areson - can you merge this in? i don't think we need to wait on rpolley as long as you tested it and it works. I've been waiting for this fix as well.

[rpolley]

@Areson seconding this, @1WindowsPuppetAdmin is probably in a better position than I am to validate that this works anyway.

[Areson]

I've released the updated version on the forge. Thanks for your patience.