Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hack-ey way to make sure materials are tracked #16

Open
abachma2 opened this issue Jul 19, 2023 · 0 comments
Open

Hack-ey way to make sure materials are tracked #16

abachma2 opened this issue Jul 19, 2023 · 0 comments
Labels
Comp:Core This issue has to do with the main bulk of the code or document. (methods, main content) Difficulty:2-Challenging This issue may be complex or require specialized skills. Priority:4-Low This work is valuable, but not urgent or mission critical. Status:1-New No one has claimed this issue yet. It is in need of solving.
Projects

Comments

@abachma2
Copy link
Collaborator

abachma2 commented Jul 19, 2023

Expected behavior:

  • call ts.Material.create_untracked() in the get_material_requests function
  • The discharged material from the archetype and and subsequent materials from that one are tracked in a simulation

Current behavior:

  • call ts.Material.create() in the get_material_requests function
  • The discharged material from the archetype and and subsequent materials from that one are tracked in a simulation

When ts.Material.create_untracked() was previously called, the discharged material from this archetype and any subsequent materials were not tracked as resources (although the transactions were recorded). This problem was previously addressed through Issue #9, with an attempted by wrong solution implemented in PR #15 (this solution recorded information to the database without actually making the materials tracked). The current behavior seems to work well enough (although it does add a lot of resources to the database), but it feels like something that the archetype shouldn't be doing.

@abachma2 abachma2 added Comp:Core This issue has to do with the main bulk of the code or document. (methods, main content) Difficulty:2-Challenging This issue may be complex or require specialized skills. Priority:4-Low This work is valuable, but not urgent or mission critical. Status:1-New No one has claimed this issue yet. It is in need of solving. labels Jul 19, 2023
@abachma2 abachma2 added this to To do in Fuel Cycles via automation Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Comp:Core This issue has to do with the main bulk of the code or document. (methods, main content) Difficulty:2-Challenging This issue may be complex or require specialized skills. Priority:4-Low This work is valuable, but not urgent or mission critical. Status:1-New No one has claimed this issue yet. It is in need of solving.
Projects
Fuel Cycles
  
To do
Development

No branches or pull requests

1 participant