Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could not fetch version info #8

Closed
francoisph opened this issue Nov 19, 2019 · 12 comments
Closed

Could not fetch version info #8

francoisph opened this issue Nov 19, 2019 · 12 comments
Assignees
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@francoisph
Copy link

Hey,

I'm trying to use your plugin. After a npm install -g npm-add-dependencies I run in my project :
npm-add-dependencies git+https://github.com/arfeo/npm-add-dependencies.git#master --dev

And I've got this :
This script adds dependencies (latest or specified versions) to the package.json file without installing them Adding packages to 'devDependencies'... Could not fetch version info for: git+https://github.com/arfeo/npm-add-dependencies.git#master. Skip. Done.

Any ideas ?
Thanks :)

@arfeo
Copy link
Owner

arfeo commented Nov 19, 2019

Hi,

Tried just now:
image

Need more info to make any decision.

Thanks.

@francoisph
Copy link
Author

Thanks for the fast response!
This is what I've got when trying the example in the README :
Capture d’écran, le 2019-11-19 à 11 43 45

@arfeo
Copy link
Owner

arfeo commented Nov 19, 2019

Any additional info for me to deal with? Have fetched packages been written to the package.json successfully, e.g.? ANY info, pls. So, I could reproduce the error. Thanks.

@arfeo
Copy link
Owner

arfeo commented Nov 19, 2019

What is this command's output:

npm show git+https://github.com/arfeo/npm-add-dependencies.git#master versions

?

@francoisph
Copy link
Author

When I'm cloning your git and run the command inside your project everything works.

When I run npm show git+https://github.com/arfeo/npm-add-dependencies.git#master versions in my project I have this :

Capture d’écran, le 2019-11-19 à 11 57 20

And the log :

Capture d’écran, le 2019-11-19 à 11 55 11

@arfeo
Copy link
Owner

arfeo commented Nov 19, 2019

Have fetched packages been written to the package.json successfully? Looks like the error with the package.json in your project's directory. Looks like there's no one. Strange enough, because in this case the script should output this: "Could not parse package.json. Stop." and stop.

@francoisph
Copy link
Author

Yes I can fetch all the packages in the package.json.
When I run in my project :
npm install git+https://github.com/arfeo/npm-add-dependencies.git#master --save

My package is correctly updated :
"npm-add-dependencies": "git+https://github.com/arfeo/npm-add-dependencies.git#master",

@arfeo
Copy link
Owner

arfeo commented Nov 19, 2019

No, I meant, have fetched packages been written to the package.json successfully after this:

image
?

@arfeo
Copy link
Owner

arfeo commented Nov 19, 2019

I think there's no way at the moment to fetch the info of a package with "git+https". I removed this from readme, and I'll think it over some time later. Thanks for this.

@arfeo arfeo added the enhancement New feature or request label Nov 19, 2019
@arfeo arfeo self-assigned this Nov 19, 2019
@arfeo
Copy link
Owner

arfeo commented Nov 19, 2019

NB: We can not use npm show git+https://github.com/author/repo#branch versions to fetch repo's versions.

@francoisph
Copy link
Author

Okay thanks for the information!

@arfeo arfeo added the wontfix This will not be worked on label Dec 28, 2019
@arfeo
Copy link
Owner

arfeo commented Dec 28, 2019

Closing the issue, since it most probably wouldn't be fixed.

@arfeo arfeo closed this as completed Dec 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants