Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change close to clear for redis #239

Merged
merged 1 commit into from May 26, 2017
Merged

Change close to clear for redis #239

merged 1 commit into from May 26, 2017

Conversation

argaen
Copy link
Member

@argaen argaen commented May 26, 2017

clear will free connections but will allow the user to
still use the cached if needed (same behavior for
aiomcache and ofc memory).

Also fix couple of ut that were depending on
Redis instance running

clear will free connections but will allow the user to
still use the cached if needed (same behavior for
aiomcache and ofc memory).

Also fix couple of ut that were depending on
Redis instance running
@codecov-io
Copy link

codecov-io commented May 26, 2017

Codecov Report

Merging #239 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #239      +/-   ##
==========================================
- Coverage   99.03%   99.03%   -0.01%     
==========================================
  Files          12       12              
  Lines         727      723       -4     
  Branches       77       77              
==========================================
- Hits          720      716       -4     
  Misses          7        7
Impacted Files Coverage Δ
aiocache/backends/memory.py 100% <ø> (ø) ⬆️
aiocache/backends/redis.py 100% <100%> (ø) ⬆️
aiocache/base.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 333119e...effc1cd. Read the comment docs.

@argaen argaen merged commit 56e9203 into master May 26, 2017
@argaen argaen deleted the close_to_clear_redis branch May 26, 2017 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants