Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi_cached can use arg for key_from_attr #271

Merged
merged 1 commit into from Jun 17, 2017

Conversation

argaen
Copy link
Member

@argaen argaen commented Jun 17, 2017

before only params defined in kwargs where working due to the
behavior defined in _get_args_dict function. This has now been
fixed and it behaves as expected.

Closes #270

before only params defined in kwargs where working due to the
behavior defined in _get_args_dict function. This has now been
fixed and it behaves as expected.
@codecov-io
Copy link

codecov-io commented Jun 17, 2017

Codecov Report

Merging #271 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #271      +/-   ##
==========================================
+ Coverage   99.17%   99.17%   +<.01%     
==========================================
  Files          13       13              
  Lines         845      850       +5     
  Branches       88       89       +1     
==========================================
+ Hits          838      843       +5     
  Misses          7        7
Impacted Files Coverage Δ
aiocache/decorators.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34e02d8...1a6307f. Read the comment docs.

@argaen argaen merged commit 1701228 into master Jun 17, 2017
@argaen argaen deleted the enhancement_#270/improve_get_args_dict_behavior branch June 17, 2017 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

multi_cached function call requires parameter name
2 participants