Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MessagePackSerializer #370

Merged
merged 10 commits into from Jan 16, 2018
Merged

Add MessagePackSerializer #370

merged 10 commits into from Jan 16, 2018

Conversation

ahopkins
Copy link
Contributor

@ahopkins ahopkins commented Dec 25, 2017

Fixes #362

@ahopkins
Copy link
Contributor Author

See #362

@argaen
Copy link
Member

argaen commented Jan 3, 2018

Thanks for the contribution! I won't have a laptop until the 9th. I'll check the builds and all that and then merge and do a new release :)

@argaen
Copy link
Member

argaen commented Jan 15, 2018

@ahopkins the msgpack requirement is missing in setup.py :). Without it build can't pass

@ahopkins
Copy link
Contributor Author

ahopkins commented Jan 15, 2018 via email

@codecov
Copy link

codecov bot commented Jan 16, 2018

Codecov Report

Merging #370 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #370   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines         836    844    +8     
  Branches       88     89    +1     
=====================================
+ Hits          836    844    +8
Impacted Files Coverage Δ
aiocache/serializers.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50a90bc...9f8edec. Read the comment docs.

@argaen
Copy link
Member

argaen commented Jan 16, 2018

I've added some changes to finish this MR and pass the tests. I have removed the use_list option because instead of hardcoding it I want to allow the user to pass it in the constructor. Next MR will be about this :).

Once I have the next MR ready and MR will do a new release with all this.

Thanks!

@argaen argaen merged commit f9b19b1 into aio-libs:master Jan 16, 2018
@ahopkins
Copy link
Contributor Author

ahopkins commented Jan 16, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants