Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WeakMultiLabels] Merge with WeakLabels using a 2 dim wl matrix #1556

Closed
dcfidalgo opened this issue Jun 13, 2022 · 1 comment · Fixed by #1577
Closed

[WeakMultiLabels] Merge with WeakLabels using a 2 dim wl matrix #1556

dcfidalgo opened this issue Jun 13, 2022 · 1 comment · Fixed by #1577
Assignees
Projects
Milestone

Comments

@dcfidalgo
Copy link
Contributor

The current implementation of the weak label matrix for multi-label classifications is overcomplicated (3-dim), and the MajorityVoter does not take advantage of the format. I propose to simplify this, basically treating rules with x labels as x rules, and remove the WeakMultiLabels class.

Pros: reduce code complexity, get the extend_matrix functionality also for multi-label cases.
Cons: if at some point we find a label model that can take advantage of the 3-dim format, we must implement a method that transforms the 2-dim format.

@dcfidalgo dcfidalgo self-assigned this Jun 13, 2022
@dcfidalgo dcfidalgo added this to Backlog in Release via automation Jun 13, 2022
@frascuchon frascuchon moved this from Backlog to Planified in Release Jun 14, 2022
@frascuchon frascuchon added this to the v0.16.0 milestone Jun 17, 2022
@dcfidalgo dcfidalgo linked a pull request Jun 22, 2022 that will close this issue
@dcfidalgo
Copy link
Contributor Author

I was looking into this in more detail, and I decided to keep the WeakMultiLabel class for now. It's harder than I thought to move it to a 2dim matrix, and I'm not sure anymore if it actually would reduce the complexity.

It was, however, relatively easy to bring the extend_matrix functionality to the 3d weak label matrix, see #1577 .

I will close this issue for now.

Release automation moved this from Planified to Waiting Release Jun 22, 2022
@frascuchon frascuchon moved this from Waiting Release to Ready to Release QA in Release Jul 6, 2022
@dcfidalgo dcfidalgo moved this from Ready to Release QA to Approved Release QA in Release Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Release
Approved Release QA
Development

Successfully merging a pull request may close this issue.

2 participants