Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Weak Labelling Rule and Api structure #1925

Open
ufukhurriyetoglu opened this issue Nov 21, 2022 · 2 comments
Open

Refactor Weak Labelling Rule and Api structure #1925

ufukhurriyetoglu opened this issue Nov 21, 2022 · 2 comments
Assignees
Labels
type: technical debt Indicates that technical debt needs to be solved

Comments

@ufukhurriyetoglu
Copy link
Contributor

    Here, we have coupled components between `Rule` and `Api`. We've already had it with the `apply` method. We can go forward as is, but we will assume the technical debt. 

If in the future we allow defining contextualized clients, as the example shows:

with rb.init("<an-url>", "<an-api-key") as client:
   client.log..
   client.load...

We need to redesign all this stuff.

Just to keep in mind.

Originally posted by @frascuchon in #1884 (comment)

@ufukhurriyetoglu ufukhurriyetoglu changed the title Here, we have coupled components between Rule and Api. We've already had it with the apply method. We can go forward as is, but we will assume the technical debt. Refactor Weak Labelling Rule and Api structure Nov 21, 2022
@ufukhurriyetoglu ufukhurriyetoglu self-assigned this Nov 21, 2022
@ufukhurriyetoglu ufukhurriyetoglu added type: technical debt Indicates that technical debt needs to be solved Labeling labels Nov 21, 2022
@ufukhurriyetoglu
Copy link
Contributor Author

@frascuchon we can proceed with this issue at future iterations.

@github-actions
Copy link

github-actions bot commented Jan 6, 2023

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the status: stale Indicates that there is no activity on an issue or pull request label Jan 6, 2023
@github-actions github-actions bot removed the status: stale Indicates that there is no activity on an issue or pull request label Jan 7, 2023
@frascuchon frascuchon self-assigned this Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: technical debt Indicates that technical debt needs to be solved
Projects
None yet
Development

No branches or pull requests

3 participants