Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] relax typer constraints #5104

Closed
davidberenstein1957 opened this issue Jun 25, 2024 · 3 comments
Closed

[FEATURE] relax typer constraints #5104

davidberenstein1957 opened this issue Jun 25, 2024 · 3 comments
Assignees
Milestone

Comments

@davidberenstein1957
Copy link
Member

Is your feature request related to a problem? Please describe.
Currently, Argilla 1 depends on typer <0.10 but currently typer is at 0.13 so it might be worth relaxing these constraitns.

Describe the solution you'd like
relax the contraints

Describe alternatives you've considered
N.A.

Additional context
N.A.

@frascuchon
Copy link
Member

we shouldn't change argilla-v1 setup. As far as I understand this problem exists already with argilla<2.0.0 right?

The argilla-v1 is a renamed package to support both SDK versions, but its behavior shouldn't be modified.

@davidberenstein1957
Copy link
Member Author

davidberenstein1957 commented Jun 25, 2024

Yes, it did, however, given that we do intend to dedicate to support fixes, I am not sure if we don't want to support things like this at all or just only want to do explicit bug fixes.

I don't know what is common practice for relaxing version constraints after deprecation but it doesn't sound very weird to do this for a certain period.

@davidberenstein1957
Copy link
Member Author

Partially resolved through this PR #5164

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants