Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add formatting_fn arg in Engine and all the subclasses #26

Closed
alvarobartt opened this issue Oct 30, 2023 · 0 comments · Fixed by #33
Closed

Add formatting_fn arg in Engine and all the subclasses #26

alvarobartt opened this issue Oct 30, 2023 · 0 comments · Fixed by #33
Assignees
Milestone

Comments

@alvarobartt
Copy link
Member

As internally discussed with @dvsrepo and @gabrielmbmb, we should add an arg in the Engine base class (former LLM class) to allow users to provide their own specific formats to send to the model, in order to detach that functionality from the Task (former PromptTemplate), which implies that users can use any available LLM available in Hugging Face even if there's not a default supported format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants