Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to delete the model #11

Closed
pradeepb28 opened this issue Feb 2, 2024 · 4 comments
Closed

Unable to delete the model #11

pradeepb28 opened this issue Feb 2, 2024 · 4 comments

Comments

@pradeepb28
Copy link

It looks like the model is deleted when I use FIleManager removeAt method but when I re-run the project the deleted model appears again.

FileManager.default.removeItem(at: URL.init(string: "file://" + "(path)")!)

@atiorh
Copy link
Contributor

atiorh commented Feb 2, 2024

Could you share more details? Is this when you are doing make download-models?

@ZachNagengast
Copy link
Contributor

Also note that the result of

let folder = try await WhisperKit.load(variant: model, from: repoName, progressCallback: { progress in
...
}

will be the exact url of the folder where the models are contained. In order to delete the entire folder, you may want to use something like this:

FileManager.default.removeItem(at: folder)

If that doesn't help then try to check the error that removeItem returns to see if it's telling you anything.

@pradeepb28
Copy link
Author

pradeepb28 commented Feb 3, 2024

@ZachNagengast curious why is there a fallback option pointed to "base model" in the framework
I found this in WhisperKit class
self.modelFolder = URL(filePath: "openai_whisperkit-base")

I wish this could be null because user already has the UI to select to which model they want to load (by default it could be none)

@ZachNagengast
Copy link
Contributor

FYI modelFolder is a now an optional, but we also have a default recommended model depending on hardware type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants