3D Object Detection Evaluation #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
March 24, 2022 19:25
benjaminrwilson
changed the title
| Each sweep is processed independently, computing assignment between detections and ground truth annotations. | ||
|
|
||
| Args: | ||
| dts: (N,15) Table of detections. |
There was a problem hiding this comment.
I think we could complement the args with, e.g.,: Table with N detections and 15 attributes? (e.g., x, y, z ...).
Comment on lines
+178
to
+182
| # # Check that there are 2 regular vehicles. | ||
| # assert gts["category"].value_counts()["REGULAR_VEHICLE"] == 2 | ||
|
|
||
| # # Check that there are no other labels. | ||
| # assert gts["category"].value_counts().sum() == 2 |
There was a problem hiding this comment.
Won't we use these?
Comment on lines
323
to
324
| breakpoint() | ||
| # read_city_SE3_ego() |
There was a problem hiding this comment.
remove breakpoint and the commented function?
Comment on lines
358
to
361
| Valid cuboids meet _two_ conditions: | ||
| 1. The cuboid's centroid (x,y,z) must lie within the maximum range in the detection configuration. | ||
| 2. The cuboid must have at _least_ one point in its interior. | ||
|
|
There was a problem hiding this comment.
Docstring might be a bit confusing as we are not using the number of points condition in this function. Or should we add is_valid_num_points: NDArrayBool = gts[:, -1] > 0 here too?
Comment on lines
+171
to
+173
| dts: (N,15) Table of detections. | ||
| gts: (M,15) Table of ground truth annotations. | ||
| cfg: Detection configuration. |
There was a problem hiding this comment.
I'd add meaning for 15 here (e.g., where 15 is the number of attributes (e.g., x, y, z).
jhonykaesemodel
approved these changes
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Testing
In order to ensure this PR works as intended, it is:
Compliance with Standards
As the author, I certify that this PR conforms to the following standards: