HTTP/2-based provider protocol #278

argon · 2015-06-17T15:22:07Z

In WWDC15 Session 720, a new provider protocol was introducted based on HTTP/2. This branch will implement the new support.

I will move this work to separate PR's

Rewrite documentation
- Sample code
Prepare API for new authentication method (JWT)

Fixes #362, #277, #240, #168

Most of this was untested. Some tests have been disabled as they directly relate to the old protocol. Next step is to selectively refactor them around HTTP/2. There's no docs yet so I'm basing this on the info in Session 720 at WWDC'15

I don't know why Sublime didnt format it this way

In the new protocol it would seem that there is no special distinction for VoIP payloads. Everything is the same length.

With the new protocol there should be no need to resend notifications as the connection remains open in the event of any errors.

With HTTP/2 it should only be necessary to keep one connection open as there will be no frequent reconnects to slow things down. If multiple are needed then the behaviour can be reintroduced after the basics are working.

node-http2 requires streams, anything less than 0.10 won't do

jorisvervuurt · 2015-12-24T18:26:02Z

FYI:
The HTTP/2 APNs provider API is now up-and running.
Documentation can be found here:
https://developer.apple.com/library/mac/documentation/NetworkingInternet/Conceptual/RemoteNotificationsPG/Chapters/APNsProviderAPI.html#//apple_ref/doc/uid/TP40008194-CH101-SW1

Any ETA as to when we can expect a first version that supports it? :)

Bluebird is generally considered to be the most performant promises library available

It's tidier than importing each function individually.

Otherwise endpointManager might not continue sending

I guess I know why I use Transform not PassThrough now.

It's unnecessary complexity...

coveralls · 2016-09-21T01:24:20Z

Coverage increased (+37.9%) to 100.0% when pulling fac557f on http2 into 805e0c0 on develop.

coveralls · 2016-09-21T01:24:38Z

Coverage increased (+37.9%) to 100.0% when pulling fac557f on http2 into 805e0c0 on develop.

coveralls · 2016-09-21T10:28:54Z

Coverage increased (+37.9%) to 100.0% when pulling bb6ad72 on http2 into 805e0c0 on develop.

coveralls · 2016-09-21T10:33:32Z

Coverage increased (+37.9%) to 100.0% when pulling 9d9c3c9 on http2 into 805e0c0 on develop.

coveralls · 2016-09-21T10:34:02Z

Coverage increased (+37.9%) to 100.0% when pulling 3a01589 on http2 into 805e0c0 on develop.

coveralls · 2016-09-21T10:37:12Z

Coverage increased (+37.9%) to 100.0% when pulling ecb79a8 on http2 into 805e0c0 on develop.

coveralls · 2016-09-21T10:37:12Z

Coverage increased (+37.9%) to 100.0% when pulling ecb79a8 on http2 into 805e0c0 on develop.

coveralls · 2016-09-21T10:42:32Z

Coverage increased (+37.9%) to 100.0% when pulling f2ab8a5 on http2 into 805e0c0 on develop.

coveralls · 2016-09-21T10:45:42Z

Coverage increased (+37.9%) to 100.0% when pulling 319dc6f on http2 into 805e0c0 on develop.

coveralls · 2016-09-21T10:45:42Z

Coverage increased (+37.9%) to 100.0% when pulling 319dc6f on http2 into 805e0c0 on develop.

coveralls · 2016-09-21T10:45:42Z

Coverage increased (+37.9%) to 100.0% when pulling 319dc6f on http2 into 805e0c0 on develop.

Ensure it's not stretched and lighten the text a little. Also centre again because it looks nicer now

coveralls · 2016-09-21T10:50:50Z

Coverage increased (+37.9%) to 100.0% when pulling 05594bf on http2 into 805e0c0 on develop.

argon added 2 commits June 17, 2015 16:16

Preparing to implement HTTP/2 version

7bbd117

Most of this was untested. Some tests have been disabled as they directly relate to the old protocol. Next step is to selectively refactor them around HTTP/2. There's no docs yet so I'm basing this on the info in Session 720 at WWDC'15

Vim changed this formatting

df60c68

I don't know why Sublime didnt format it this way

argon changed the title ~~[WIP] HTTP/2-based provider protocol 🚧~~ [WIP] HTTP/2-based provider protocol :con Jun 17, 2015

argon changed the title ~~[WIP] HTTP/2-based provider protocol :con~~ [WIP] HTTP/2-based provider protocol 🚧 Jun 17, 2015

argon changed the title ~~[WIP] HTTP/2-based provider protocol 🚧~~ [WIP] HTTP/2-based provider protocol 🚧 Jun 17, 2015

argon mentioned this pull request Jun 17, 2015

Support for new HTTP/2 provider API #277

Closed

argon added 20 commits June 20, 2015 01:20

Install the httpd2 module

37598ea

Remove the VoIP flag

aaea6d5

In the new protocol it would seem that there is no special distinction for VoIP payloads. Everything is the same length.

Increase the payload length to 4KB

101134e

Remove the concept of caching notifications

9a06774

With the new protocol there should be no need to resend notifications as the connection remains open in the event of any errors.

Remove the concept of maxConnections

8497072

With HTTP/2 it should only be necessary to keep one connection open as there will be no frequent reconnects to slow things down. If multiple are needed then the behaviour can be reintroduced after the basics are working.

Remove reference to an old configuration option

6126ee7

Remove the gateway initialization option

7048a47

Use the new (assumed) endpoint addresses

c7f93e4

Require http2 for request invocation

34713a5

Use POST method for requests

edb5aa2

Remove node-0.8 support

db91c4e

node-http2 requires streams, anything less than 0.10 won't do

Add initial Endpoint behaviour

3f6f3d9

Only support the latest-and-greatest

f6eb75c

Remove legacy setImmediate wrapper

438d66a

Setup the event emitter first

ba64932

Invoke connect on initialization

718f24d

Rename some methods to show they're internal

3184385

Test the fake logger behaves correctly

7ec216c

Set important TLS options

3882e39

Clean up the tests a little

9c47f0b

argon added 3 commits January 3, 2016 23:18

Switch from q to bluebird for promises

c9f64b5

Bluebird is generally considered to be the most performant promises library available

Consolidate the credential functions

3ae0df9

It's tidier than importing each function individually.

Tidy up the event emitter setup

28c2c51

argon added 7 commits September 21, 2016 01:04

Ensure that end gets bubbled

fe3b835

Otherwise endpointManager might not continue sending

Correct a weird comment

9de3e60

Use realistic stream ID's

5551e22

Handle GOAWAY events

0e01d49

Resend notes from unprocessed streams

f82837f

Fix the broken test

052feb2

I guess I know why I use Transform not PassThrough now.

Remove bluebird fallback

fac557f

It's unnecessary complexity...

argon added 2 commits September 21, 2016 10:29

Fix Codacy issues

8b5ae99

Update the README

bb6ad72

argon added 2 commits September 21, 2016 11:30

Add syntax hightling hints

9d9c3c9

Outdent the code examples

3a01589

Update the sample code

ecb79a8

argon changed the title ~~[WIP] HTTP/2-based provider protocol 🚧~~ HTTP/2-based provider protocol Sep 21, 2016

argon added 2 commits September 21, 2016 11:40

Update the header a little

f2ab8a5

Move logo back to the left

319dc6f

Fix the logo

05594bf

Ensure it's not stretched and lighten the text a little. Also centre again because it looks nicer now

argon merged commit 607b14d into develop Sep 21, 2016

argon deleted the http2 branch September 21, 2016 10:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HTTP/2-based provider protocol #278

HTTP/2-based provider protocol #278

argon commented Jun 17, 2015 •

edited

Loading

jorisvervuurt commented Dec 24, 2015

coveralls commented Sep 21, 2016 •

edited

Loading

coveralls commented Sep 21, 2016 •

edited

Loading

coveralls commented Sep 21, 2016 •

edited

Loading

coveralls commented Sep 21, 2016 •

edited

Loading

coveralls commented Sep 21, 2016 •

edited

Loading

coveralls commented Sep 21, 2016 •

edited

Loading

coveralls commented Sep 21, 2016

coveralls commented Sep 21, 2016 •

edited

Loading

coveralls commented Sep 21, 2016

coveralls commented Sep 21, 2016

coveralls commented Sep 21, 2016

coveralls commented Sep 21, 2016 •

edited

Loading

HTTP/2-based provider protocol #278

HTTP/2-based provider protocol #278

Conversation

argon commented Jun 17, 2015 • edited Loading

jorisvervuurt commented Dec 24, 2015

coveralls commented Sep 21, 2016 • edited Loading

coveralls commented Sep 21, 2016 • edited Loading

coveralls commented Sep 21, 2016 • edited Loading

coveralls commented Sep 21, 2016 • edited Loading

coveralls commented Sep 21, 2016 • edited Loading

coveralls commented Sep 21, 2016 • edited Loading

coveralls commented Sep 21, 2016

coveralls commented Sep 21, 2016 • edited Loading

coveralls commented Sep 21, 2016

coveralls commented Sep 21, 2016

coveralls commented Sep 21, 2016

coveralls commented Sep 21, 2016 • edited Loading

argon commented Jun 17, 2015 •

edited

Loading

coveralls commented Sep 21, 2016 •

edited

Loading

coveralls commented Sep 21, 2016 •

edited

Loading

coveralls commented Sep 21, 2016 •

edited

Loading

coveralls commented Sep 21, 2016 •

edited

Loading

coveralls commented Sep 21, 2016 •

edited

Loading

coveralls commented Sep 21, 2016 •

edited

Loading

coveralls commented Sep 21, 2016 •

edited

Loading

coveralls commented Sep 21, 2016 •

edited

Loading