Skip to content
This repository has been archived by the owner on Oct 12, 2023. It is now read-only.

TestGetFileContent test is failing when running go test, on Mac #246

Merged
merged 1 commit into from May 28, 2021

Conversation

jgwest
Copy link
Member

@jgwest jgwest commented May 26, 2021

This PR:

  • fixes the failing test: Mac OSX doesn't use /tmp as its temporary directory (unlike Linux), so the test was failing when run outside the container. This switches to using the system temporary directory from Go.

Fixes #245

@jgwest jgwest marked this pull request as ready for review May 26, 2021 13:24
@jgwest jgwest requested a review from wtam2018 May 26, 2021 13:24
Copy link
Collaborator

@wtam2018 wtam2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
thanks @jgwest !

@jgwest jgwest merged commit 65c4caf into argoproj:master May 28, 2021
@jgwest jgwest deleted the fix-testgetfilecontent-mac-245 branch May 28, 2021 12:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestGetFileContent test is failing when running go test, on Mac
3 participants