Skip to content
This repository has been archived by the owner on Jul 15, 2024. It is now read-only.

Added additional path params to Git File Generator #260

Merged
merged 1 commit into from
Jun 10, 2021
Merged

Added additional path params to Git File Generator #260

merged 1 commit into from
Jun 10, 2021

Conversation

ishitasequeira
Copy link
Member

@ishitasequeira ishitasequeira commented Jun 8, 2021 •
edited
Loading

Add {{ path }} and {{ path.basename }} params to git file generator.

Fixes: #258

Signed-off : Ishita Sequeira

@CLAassistant
Copy link

CLAassistant commented Jun 8, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ishitasequeira ishitasequeira marked this pull request as ready for review June 8, 2021 19:49
@ishitasequeira
Copy link
Member Author

@jgwest PTAL the PR is ready for review

@jgwest jgwest self-requested a review June 10, 2021 12:13
jgwest
jgwest approved these changes Jun 10, 2021
View reviewed changes
Copy link
Member

@jgwest jgwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @ishitasequeira!

@jgwest jgwest merged commit 6481708 into argoproj:master Jun 10, 2021
@jgwest jgwest mentioned this pull request Jul 19, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jgwest jgwest jgwest approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Git file generator should support {{path}}
3 participants
@ishitasequeira @CLAassistant @jgwest