This repository has been archived by the owner on Oct 12, 2023. It is now read-only.
fix: improve git files generator performance #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
alexmt
force-pushed
the
354-file-generator-performance
branch
from
36d8557
to
74e5561
Compare
jgwest
approved these changes
Aug 31, 2021
There was a problem hiding this comment.
Looks great, thanks @alexmt! The only minor disadvantage to this approach is it will read the full file contents of matching paths into memory (causing spiky heap allocation) but since it will only read files that match the path (which tend to be smallish .json and .yaml files), this is perfectly fine.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alexander Matyushentsev AMatyushentsev@gmail.com
Closes #354
PR changes repo services implementation: replaces
GetFilePathsandGetFileContentmethods withGetFilesthat checkout/fetch repo once and return content of discovered files.