Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[148] - Healthcheck endpoint returns application/json content type #367

Conversation

bobstrecansky
Copy link
Contributor

This is a draft to attempt to change the content type of the Healthcheck endpoint for this application from appliation/json to text/plain.

I don't currently have access to an environment where I can test this change, that's hindering me from validating this change.

@CLAassistant
Copy link

CLAassistant commented Oct 13, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@bobstrecansky
Copy link
Contributor Author

I've also signed the CLA, but for some reason the bot is mentioning that I haven't. It might be due to my different naming convention for my PR (I use bobstrecansky-mc and bobstrecansky, not sure what the conventions are for this repo)

@bobstrecansky bobstrecansky marked this pull request as ready for review October 13, 2022 19:03
@bobstrecansky bobstrecansky force-pushed the 148-health-check-endpoint-returns-application-json-content-type branch from b543894 to 18a51f6 Compare October 13, 2022 19:24
@bobstrecansky bobstrecansky force-pushed the 148-health-check-endpoint-returns-application-json-content-type branch from b1211b6 to d8785a8 Compare October 18, 2022 17:45
@bobstrecansky
Copy link
Contributor Author

Closing in favor of : #368

@bobstrecansky bobstrecansky deleted the 148-health-check-endpoint-returns-application-json-content-type branch October 18, 2022 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants