Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted notifications being send by kube-notifier-controller #19

Open
tiej-dr opened this issue May 25, 2020 · 2 comments
Open

Deleted notifications being send by kube-notifier-controller #19

tiej-dr opened this issue May 25, 2020 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@tiej-dr
Copy link

tiej-dr commented May 25, 2020

Describe the bug
When a notification is deleted it's not reflected in "kube-notifier-controller" - resulting in notifications being send after deletion.

To Reproduce

  1. Create notification. E.g
    kubectl apply -f hello-notifier.yaml -n hello-app
    .. trigger notification condition to check a notification is send.

  2. Delete notification:
    kubectl delete notifications.argoproj.io hello-notifier -n hello-app

  3. Trigger notification condition again, resulting in notification is being send again, even if it's been deleted.

Expected behavior
When a given notification is deleted, kube-notifier-controller should not send any notifications of given kind.

Additional context
In order to update "kube-notifier-controller" with latest changes (notification deletion), i had to restart controller manually (by deleting pod)

@sarabala1979 sarabala1979 added the help wanted Extra attention is needed label Jul 17, 2020
@sarabala1979
Copy link
Collaborator

@tiej-dr do you like to contribute?

@tiej-dr
Copy link
Author

tiej-dr commented Aug 3, 2020

@tiej-dr do you like to contribute?

@sarabala1979 , haven't much of golang experience, and not sure how much time I will have for it, but if you have time to set me up and point me in the right direction I'm willing to give it a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants