Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect comparison in code in reconcileRolloutsDeployment function in deployments.go file #43

Closed
Rizwana777 opened this issue Feb 21, 2024 · 0 comments
Closed

Incorrect comparison in code in reconcileRolloutsDeployment function in deployments.go file #43

Rizwana777 opened this issue Feb 21, 2024 · 0 comments
Assignees
@Rizwana777
Labels
bug Something isn't working

Comments

@Rizwana777
Copy link
Collaborator

The comparison !reflect.DeepEqual(actualPodSpec.Containers[0], desiredPodSpec.Containers) in the code snippet is incorrect. This is comparing actualPodSpec.Containers[0] (first index)and desiredPodSpec.Containers(slice) which is incorrect. As a result the comparison may not behave as expected and could lead to unintended consequences.
@Rizwana777 Rizwana777 self-assigned this Feb 21, 2024
@Rizwana777 Rizwana777 added the bug Something isn't working label Feb 22, 2024
@Rizwana777 Rizwana777 mentioned this issue Feb 22, 2024
Merged
@jgwest jgwest closed this as completed Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rizwana777 Rizwana777

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jgwest @Rizwana777