Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packr management issues #76

Closed
sestegra opened this issue Jun 1, 2021 · 2 comments · Fixed by #77
Closed

Packr management issues #76

sestegra opened this issue Jun 1, 2021 · 2 comments · Fixed by #77

Comments

@sestegra
Copy link
Contributor

sestegra commented Jun 1, 2021

After investigating issue on #31, I found the following recommandation about packr.

Please consider migrating your projects to github.com/markbates/pkger

Then, static option should be removed from hack/build.sh to support macOS on arm64 architecture: see Homebrew/homebrew-core#78460.

@roi-codefresh
Copy link
Contributor

We actually only use packr because we have a dependency on argo-cd which is using packr to embed some static files in their binary.

I think there are two possible ways to resolve it (besides upgrading to github.com/markbates/pkger):

  1. we can make a pr to argo-cd and replace the use of packr to the built-in embed go module.
  2. If I understand correctly what packr is doing is just generating *.go files that contain the data to be embedded, then they compile the source code with those files and finally they clean the generated files. We could potentially just keep the generated file (commit it) and compile with it, then we can stop using packr.

@roi-codefresh roi-codefresh linked a pull request Jun 1, 2021 that will close this issue
@roi-codefresh
Copy link
Contributor

Argo-cd actually just removed the dependency on packr two weeks ago with this commit. However it is not yet present on the latest release, which is v2.0.3. For the meantime I have implemented some hack to remove our dependency on packr, but if we upgrade to a newer version of argo-cd this hack would no longer work and hopefully there would be no issues making it work with go-embbed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants