Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Trigger image update check on incoming webhook and/or other triggers #1

Open
jannfis opened this issue Aug 6, 2020 · 18 comments
Labels
enhancement New feature or request
Milestone

Comments

@jannfis
Copy link
Contributor

jannfis commented Aug 6, 2020

Is your feature request related to a problem? Please describe.

Currently, ArgoCD Image Updater only polls container registries for new tags at a given interval. Depending on the number of images and registries to be checked, this can lead to an overwhelming number of requests and takes a lot of time.

Describe the solution you'd like

Update checks for images should also be triggered asynchronously, i.e. by a webhook on image push to the registry.

@jannfis jannfis added the enhancement New feature or request label Aug 6, 2020
@jannfis jannfis added this to the v1.0.0 milestone Aug 6, 2020
@ghostheory
Copy link

Per some of the constraints at my employer, this feature would be a game changer there. I was wondering if there is a timeline on this, and if there is anything I can do to help (unfortunately, I do not know Go).

@Ladorie
Copy link

Ladorie commented Mar 23, 2021

Per some of the constraints at my employer, this feature would be a game changer there. I was wondering if there is a timeline on this, and if there is anything I can do to help (unfortunately, I do not know Go).

I second this feature. Would be very helpful for us as well.

@tylerbroadbent
Copy link

Same here! This would be a game changer and extremely valuable!

@joshdwads
Copy link

Serious game changer! This would be a great add.

@nikelsj11
Copy link

+1

@alexisbel1
Copy link

Game changer here!

@gastonborba
Copy link

Same here!

@tuananh
Copy link

tuananh commented Nov 18, 2021

@gastonborba i opened a PR earlier here. it's wip #284

@Disturbing
Copy link

Plz do this

@djfinnoy
Copy link

It would be amazing if the image updater could be triggered through the git webhook for refreshing argocd apps.

Git repositories POST to https://argocd.example.com/api/webhook, the image updater triggers for applications with annotations that match the git webhook. That way, all the user has to do is set some annotations, and then get a free ride with the existing ArgoCD git webhook functionality.

@tuananh
Copy link

tuananh commented Apr 28, 2022

git webhook is triggered very early in the CI process. at that moment, CI was just trigger and image is not built in.

the other information is git webhook payload doesn't have any information of the image tag, so image updater doesn't know which one to use for updating either.

@chenfli
Copy link

chenfli commented May 10, 2022

How about when the CI process completed the image creating it will send a web request to ArgoCD ? is it already implemented on Argo Events ?

@binhnguyenduc
Copy link

This would be a game changer for us as well. With a growing number of repositories and images, it takes quite sometime to update new image and it is slowing down our CD

@tuananh
Copy link

tuananh commented Oct 12, 2022

This would be a game changer for us as well. With a growing number of repositories and images, it takes quite sometime to update new image and it is slowing down our CD

Maybe you can continue on this pr #284

@gain620
Copy link

gain620 commented Feb 5, 2023

Any updates on this feature?

@otherguy
Copy link

otherguy commented Mar 3, 2023

Would be amazing to have

@MrCorncob
Copy link

tracking hundreds of images and my GCP project has exceeded the Snapshot api limit, this feature is really really important imo

@victorbiga
Copy link

This could be the implementation of API request as /api/webhook?name=app-name, however this is thin line.
Github Webhook currently does not support OIDC or any other ways of authenticating, therefore wanting for the new rollout to start by un-authenticated request or not is another question

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests