Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ext/git): Branch method not call runCmd correctly #213

Merged
merged 2 commits into from Jun 11, 2021

Conversation

huhudev-git
Copy link
Contributor

@huhudev-git huhudev-git commented Jun 11, 2021

fix if use Branch(), it will type git command twice

  • current
git git checkout sourceBranch
git git branch targetBranch
  • fixed
git checkout sourceBranch
git branch targetBranch

@CLAassistant
Copy link

CLAassistant commented Jun 11, 2021

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jun 11, 2021

Codecov Report

Merging #213 (f54dcbc) into master (7708118) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #213   +/-   ##
=======================================
  Coverage   66.77%   66.77%           
=======================================
  Files          20       20           
  Lines        1574     1574           
=======================================
  Hits         1051     1051           
  Misses        424      424           
  Partials       99       99           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7708118...f54dcbc. Read the comment docs.

Copy link
Contributor

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @huhudev-git !

@jannfis jannfis merged commit 45e6486 into argoproj-labs:master Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants