Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

envs key in configMapGenerator and secretGenerator of Kustomize app disappears after image update #315

Closed
ikaruswill opened this issue Dec 10, 2021 · 1 comment
Labels
bug Something isn't working help wanted Extra attention is needed
Milestone

Comments

@ikaruswill
Copy link

Describe the bug
Image updates remove envs key from secretGenerator and configMapGenerator in kustomization.yaml

Commit diff:

diff --git a/apps/personal/photoprism/kustomization.yaml b/apps/personal/photoprism/kustomization.yaml
index a4d78692..2d5ab611 100644
--- a/apps/personal/photoprism/kustomization.yaml
+++ b/apps/personal/photoprism/kustomization.yaml
@@ -16,14 +16,10 @@ commonLabels:
 
 secretGenerator:
 - name: photoprism
-  envs:
-  - files/secret.env
 
 configMapGenerator:
 - name: photoprism
-  envs:
-  - files/config.env
 
 images:
 - name: photoprism/photoprism
-  newTag: "20211203"
+  newTag: "20211210"

To Reproduce

  1. Have a Kustomize app annotated for updating.
  2. Kustomize app references the same repository as the Application itself (probably irrelevant)
  3. Kustomize app has both secretGenerator and configMapGenerator
  4. Each of those options have an envs key
  5. In that key, contains a single entry referencing an env style file containing key-value pairs
  6. Trigger an image update on the container registry
  7. Check commit by image updater

Expected behavior
envs key should not be deleted due to an image update

Additional context
None

Version
v0.11.0

Logs
No relevant logs, all log entries show success

@ikaruswill ikaruswill added the bug Something isn't working label Dec 10, 2021
@jannfis jannfis added this to the v0.12.0 milestone Dec 16, 2021
@jannfis jannfis added the help wanted Extra attention is needed label Dec 16, 2021
@ikaruswill
Copy link
Author

Just to update, this issue is fixed ever since I updated to v0.11.2.

Thanks a lot for keeping this in view.

Closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants