Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ability to set annotations+labels on pods created by argocd #637

Open
Morriz opened this issue May 5, 2022 · 5 comments · May be fixed by #1009
Open

ability to set annotations+labels on pods created by argocd #637

Morriz opened this issue May 5, 2022 · 5 comments · May be fixed by #1009
Assignees
@iam-veeramalla
Labels
triage:required

Comments

@Morriz
Copy link

Morriz commented May 5, 2022 •
edited

Is your feature request related to a problem? Please describe.
Hi, we need to set annotations on any pods running on our cluster, but I can't find the option to do so on pods deployed by argo.

Describe the solution you'd like
Something like:

apiVersion: argoproj.io/v1alpha1
kind: ArgoCD
...
controller:
  podAnnotations:
    some: anno
  labels:
    some: label
...
server:
  podAnnotations:
    ana: da
@Morriz
Copy link
Author

Morriz commented May 5, 2022

A better question to ask is: Why does the operator not support the exact same options as the helm charts? Istio Operator does the same, as do other operators. It would be trivial and super beneficial

@Morriz Morriz changed the title ability to set annotations on pods created by argo ability to set annotations on pods created by argocd May 5, 2022
@Morriz Morriz changed the title ability to set annotations on pods created by argocd ability to set annotations+labels on pods created by argocd May 5, 2022
@iam-veeramalla
Copy link
Collaborator

@Morriz I agree it is very useful, but I see a concern with operator reconciling the labels and annotations. There is a good chance that operator may removes annotations/labels set by admission controllers. WDYT ?

@iam-veeramalla iam-veeramalla self-assigned this May 13, 2022
@Morriz
Copy link
Author

Morriz commented May 18, 2022 •
edited

@Morriz I agree it is very useful, but I see a concern with operator reconciling the labels and annotations. There is a good chance that operator may removes annotations/labels set by admission controllers. WDYT ?

That is a matter of having a mature operator that allows for labels it does not manage. That is why one namespaces them, in order to filter.

@iam-veeramalla
Copy link
Collaborator

LGTM. Would you like to work on this one ? If not I can add the label help-wanted and remove traige-required.

Thanks @Morriz

@Morriz
Copy link
Author

Morriz commented May 18, 2022

I am no Go dev unfortunately, and my calendar is rather full ;|

@matthewhembree matthewhembree mentioned this issue Feb 24, 2023
Open
@AlexanderThaller AlexanderThaller linked a pull request Sep 26, 2023 that will close this issue
Draft
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iam-veeramalla iam-veeramalla

Labels
triage:required
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ability to set annotations+labels on pods created by argocd AlexanderThaller/argocd-operator
2 participants
@Morriz @iam-veeramalla