Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for application namespaces #787

Open
tongpu opened this issue Sep 27, 2022 · 3 comments
Open

Add support for application namespaces #787

tongpu opened this issue Sep 27, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@tongpu
Copy link

tongpu commented Sep 27, 2022

Is your feature request related to a problem? Please describe.
In argoproj/argo-cd#9755 Argo CD gained support for pulling in Application from outside of the namespace Argo CD is being deployed.

Describe the solution you'd like
As this feature will be added to Argo CD 2.5 I would be happy if argocd-operator would be able to support this parameter.

@iam-veeramalla iam-veeramalla added the enhancement New feature or request label Oct 11, 2022
@iam-veeramalla
Copy link
Collaborator

@ishitasequeira is already working on this one. Thanks for raising the enhancement @tongpu

@Gentoli
Copy link

Gentoli commented May 4, 2023

If there is spec.controller.extraCommandArgs, this config would work:

apiVersion: argoproj.io/v1alpha1
kind: ArgoCD
metadata:
  name: example-argocd
  labels:
    example: server
spec:
  resourceTrackingMethod: annotation+label
  controller:
   # Does not exists 
    extraCommandArgs:
      - '--application-namespaces=*'
  server:
    extraCommandArgs:
      - '--application-namespaces=*'

This will allow the user to use new features before they are supported by the operator.

I also see --application-namespaces is generated from spec.sourceNamespaces, but setting it to ["*"] will cause this error when reconciling Role(?):

1.6831749006287725e+09	ERROR	controller.argocd	Reconciler error	{"reconciler group": "argoproj.io", "reconciler kind": "ArgoCD", "name": "app", "namespace": "argocd", "error": "Namespace \"*\" not found"}

My current workaround is to disable the operator...

@timurgaleev
Copy link

is there any news here? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants