Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support user specified Bearer tokens #1053

Merged
merged 10 commits into from
May 7, 2024
Merged

Support user specified Bearer tokens #1053

merged 10 commits into from
May 7, 2024

Conversation

flaviuvadan
Copy link
Collaborator

Pull Request Checklist

See #1016 for a description provided by users. This PR adds support for user specified Bearer tokens while providing a backwards compatible experience.

Signed-off-by: Flaviu Vadan <flaviuvadan@gmail.com>
Signed-off-by: Flaviu Vadan <flaviuvadan@gmail.com>
@flaviuvadan flaviuvadan added type:enhancement A general enhancement semver:minor A change requiring a minor version bump labels May 2, 2024
Signed-off-by: Flaviu Vadan <flaviuvadan@gmail.com>
Signed-off-by: Flaviu Vadan <flaviuvadan@gmail.com>
Signed-off-by: Flaviu Vadan <flaviuvadan@gmail.com>
src/hera/events/service.py Outdated Show resolved Hide resolved
Signed-off-by: Flaviu Vadan <flaviuvadan@gmail.com>
src/hera/events/service.py Outdated Show resolved Hide resolved
flaviuvadan and others added 2 commits May 7, 2024 10:42
Co-authored-by: Sambhav Kothari <skothari44@bloomberg.net>
Signed-off-by: Flaviu Vadan <flaviuvadan@gmail.com>
@flaviuvadan flaviuvadan enabled auto-merge (squash) May 7, 2024 14:43
@flaviuvadan
Copy link
Collaborator Author

CC @ljyanesm @Adam-D-Lewis

Signed-off-by: Flaviu Vadan <flaviuvadan@gmail.com>
@flaviuvadan flaviuvadan merged commit b841f6c into main May 7, 2024
20 checks passed
@flaviuvadan flaviuvadan deleted the fv/1016 branch May 7, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:minor A change requiring a minor version bump type:enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hera's token handling feels a bit awkward
3 participants