fix: access undefined spec.template when using workloadRef #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
httin
force-pushed
the
feat/undefined-spec-template
branch
from
f4e0452
to
6022db1
Compare
|
@rbreeze can we get this reviewed and merged, please? 🙏 |
|
We're also affected by this bug. |
rbreeze
approved these changes
Sep 10, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the issue #2
When Rollout uses
workloadRef, thespec.templateisundefined, this will prevent the page from being crashed. However, the containers's name are not going to display, we need to parse the Deployment from source tree in order to get the containers information.