fix(argocd_cluster): use cluster list api to avoid 403 issues with cluster get api at cluster read time #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w4rgrum
force-pushed
the
fix/argocd_cluster/issue-266-use-list-api-to-read
branch
5 times, most recently
from
d2ffd2a
to
d5d059c
Compare
…uster get api at cluster read time Signed-off-by: Hugo HARS <54102154+w4rgrum@users.noreply.github.com>
w4rgrum
force-pushed
the
fix/argocd_cluster/issue-266-use-list-api-to-read
branch
from
d5d059c
to
ca58239
Compare
|
@onematchfox PR is ready to be reviewed :) |
|
any chance to have this released as new version of the provider? This seems to be a blocker when using the provider with recent ArgoCD versions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #266
Coded it with below comment in mind, meaning it is backward compatible: #266 (comment)
Getas usual first (legacy code)PermissionDeniederror (i.e.403) the fix is triggered (in a backward compatible way for servers <v2.8, see below)In that case a call is issued to the
Listapi, reusing some code used for create cluster existence checks (that already uses thisListapi). Noe that this code is able to filter the cluster in the resulting list if not yet done by the ArgoCD server (servers filtering onListapi does not work if <v2.8, see comments in linked issue and/or in the code ccomments)Also added a non-regression test to validate a server-side deletion of the cluster triggers the fix.