Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for finalizers in metadata. #391

Open
KyriosGN0 opened this issue May 8, 2024 · 1 comment · May be fixed by #409
Open

add support for finalizers in metadata. #391

KyriosGN0 opened this issue May 8, 2024 · 1 comment · May be fixed by #409
Labels
enhancement New feature or request

Comments

@KyriosGN0
Copy link

Description

we recently had a use case of migration from one appset to another and needed an ability to set a finalizer on the appset

Potential Terraform Configuration

resource "argocd_application_set" "services-test" {
  metadata {
    name = "appsetname"
    finalizers = [
    - final
    ]
  }


  spec {
    generator {
      git {
        repo_url = "server"
        revision = "master"

        file {
          path = "clusters/*/*/*/values.yaml"
        }
      }
    }

    template {
      metadata {
        name = "{{path[3]}}-{{path[2]}}"

        labels = {
          env = "{{path[1]}}"
        }
      }

      spec {
        project                = "default"
        revision_history_limit = 3

        source {
          repo_url        = "server"
          target_revision = "master"
          path            = "charts/"
          helm {
            release_name               = "{{path[3]}}"
            value_files                = ["values.yaml", "../../clusters/{{path[1]}}/{{path[2]}}/{{path[3]}}/values.yaml"]

            parameter {
              name  = "clusterName"
              value = "{{path[2]}}"
            }
          }
        }

        destination {
          name      = "{{path[2]}}"
          namespace = "{{path[3]}}"
        }

        sync_policy {
          sync_options = [
            "ServerSideApply=true",
            "CreateNamespace=true"
          ]
        }
      }
    }
  }
}

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@KyriosGN0 KyriosGN0 added the enhancement New feature or request label May 8, 2024
@tkaesserfm
Copy link

In my opinion not supporting finalizer kind of renders provider useless at least for our majority of usecases. Would be really nice to have!

@KyriosGN0 KyriosGN0 linked a pull request Jul 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants