Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CloudEvents sdk-go #234

Closed
dtaniwaki opened this issue Mar 17, 2019 · 8 comments
Closed

Use CloudEvents sdk-go #234

dtaniwaki opened this issue Mar 17, 2019 · 8 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@dtaniwaki
Copy link
Member

dtaniwaki commented Mar 17, 2019

Is your feature request related to a problem? Please describe.

N/A

Describe the solution you'd like

Use https://github.com/cloudevents/sdk-go to easily support cloudevent (v0.2).

Describe alternatives you've considered

N/A

Additional context

I think we should use cloudevents sdk-go to support various types of event protocol instead of implementing it by ourselves, and also to update event spec easily.

@VaibhavPage
Copy link
Contributor

Definitely. We can add this as a part of the work required for EventSource CRD which will be the focus after v1.0.

We should also start fleshing out the roadmap for v2.0

@VaibhavPage VaibhavPage modified the milestone: v0.10 Mar 30, 2019
@VaibhavPage VaibhavPage added this to the v0.10 milestone Aug 2, 2019
@VaibhavPage VaibhavPage added the enhancement New feature or request label Aug 2, 2019
@VaibhavPage VaibhavPage modified the milestones: v0.10, v0.11 Aug 2, 2019
@dtaniwaki
Copy link
Member Author

Nats streaming has not been supported in cloudevents sdk-go.
However, there's a PR for the feature.
cloudevents/sdk-go#136

@dtaniwaki
Copy link
Member Author

I found the current format is slightly different from the examples in CloudEvents v0.1.

Here's a current format example.

{"context":{"eventType":"webhook","eventTypeVersion":"v0.10","cloudEventsVersion":"0.1","source":{"scheme":"","user":"","password":"","host":"webhook-gateway:example","port":0,"path":"","query":"","fragment":""},"eventID":"32663132666664612d623661642d313165392d383366612d303234326163313130303161","eventTime":"2019-08-04T11:44:14.688738Z","schemaURL":null,"contentType":"application/json"},"payload":null}

@VaibhavPage Do you know why we're using a different format? Can we start to use the correct format?

I will also support v0.2 and v0.3 format after implementing cloud SDK adoption with v0.1.

@n3wscott
Copy link

👀

@VaibhavPage
Copy link
Contributor

I think when I referred to spec, it was even before v0.1, thats why the discrepancies.

@dtaniwaki
Copy link
Member Author

So, can I change the format of v0.1?

@VaibhavPage
Copy link
Contributor

yep.

@VaibhavPage
Copy link
Contributor

Closing the issue. This is implemented and cloud-events-sdk is part of Argo-Events,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants