Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webhook multiple http registrations #73

Closed
magaldima opened this issue Jul 27, 2018 · 1 comment
Closed

webhook multiple http registrations #73

magaldima opened this issue Jul 27, 2018 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@magaldima
Copy link
Contributor

Describe the bug
An error is encountered in the webhook signal when you have a webhook with a certain path, delete it, and then re-create it with the same path. (assuming both signal streams connect to the same webhook signal pod and the pod doesn't die between requests)

To Reproduce
Steps to reproduce the behavior:

  1. k create -f examples/webhook-sensor.yaml
  2. k delete sensor webhook-example
  3. k create -f examples/webhook-sensor.yaml

Expected behavior
One should be able to delete and re-create sensors without having to modify and/or change the spec.

Additional context
This is related to how multiplexers & servers work. We were initially creating a separate server with a new ServeMux on every Listen(), however we cannot do this since we cannot start 2 servers listening on the same port (and now the port is fixed at signal startup).

@magaldima magaldima added bug Something isn't working new labels Jul 27, 2018
@magaldima magaldima added this to the v1.0.0 milestone Jul 27, 2018
@VaibhavPage
Copy link
Contributor

addressed in #92 . A webhook gateway can be configured with multiple endpoint with different http methods. Deleting and recreating sensor has no effect on gateway as they are completely decoupled from each other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants