Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update contributions.md to include k3d as recommended cluster, add details on e2e test setup, and update kubectl install link. Fixes #1750 #1867

Merged
merged 3 commits into from
Apr 4, 2023

Conversation

danielhelfand
Copy link
Contributor

@danielhelfand danielhelfand commented Feb 17, 2022

Closes #1750

Also documents some cluster setup steps under running e2e test section and updates kubectl install link.

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Signed-off-by: Daniel Helfand <helfand.4@gmail.com>
Signed-off-by: Daniel Helfand <helfand.4@gmail.com>
Signed-off-by: Daniel Helfand <helfand.4@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Feb 17, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #1867 (ee49139) into master (d3c305c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1867   +/-   ##
=======================================
  Coverage   82.36%   82.36%           
=======================================
  Files         119      119           
  Lines       16872    16872           
=======================================
  Hits        13897    13897           
  Misses       2284     2284           
  Partials      691      691           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3c305c...ee49139. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2022

This PR is stale because it has been open 90 days with no activity.

@zachaller zachaller merged commit f9a3914 into argoproj:master Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Argo Rollouts docs should prioritize k3d
2 participants