Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix the controller annotation to enable data scrapping #2238

Merged

Conversation

perenesenko
Copy link
Member

Signed-off-by: Andrii Perenesenko andrii.perenesenko@gmail.com

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Signed-off-by: Andrii Perenesenko <andrii.perenesenko@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Sep 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2022

Go Published Test Results

1 739 tests   1 739 ✔️  2m 33s ⏱️
   101 suites         0 💤
       1 files           0

Results for commit 62e53f8.

@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #2238 (62e53f8) into master (3f0dab0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2238   +/-   ##
=======================================
  Coverage   82.37%   82.37%           
=======================================
  Files         121      121           
  Lines       18099    18099           
=======================================
  Hits        14909    14909           
  Misses       2419     2419           
  Partials      771      771           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2022

E2E Tests Published Test Results

  1 files    1 suites   44m 18s ⏱️
88 tests 83 ✔️ 3 💤 2
90 runs  85 ✔️ 3 💤 2

For more details on these failures, see this check.

Results for commit 62e53f8.

@zachaller zachaller added the ready-for-review Ready for final review label Sep 9, 2022
@jessesuen jessesuen merged commit df8af6d into argoproj:master Sep 19, 2022
daixijun pushed a commit to daixijun/argo-rollouts that referenced this pull request Sep 27, 2022
…j#2238)

Signed-off-by: Andrii Perenesenko <andrii.perenesenko@gmail.com>
Signed-off-by: Xijun Dai <daixijun1990@gmail.com>
jenciso pushed a commit to jenciso/argo-rollouts that referenced this pull request Oct 25, 2022
…j#2238)

Signed-off-by: Andrii Perenesenko <andrii.perenesenko@gmail.com>
jandersen-plaid pushed a commit to jandersen-plaid/argo-rollouts that referenced this pull request Nov 8, 2022
…j#2238)

Signed-off-by: Andrii Perenesenko <andrii.perenesenko@gmail.com>
jandersen-plaid pushed a commit to jandersen-plaid/argo-rollouts that referenced this pull request Nov 26, 2022
…j#2238)

Signed-off-by: Andrii Perenesenko <andrii.perenesenko@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review Ready for final review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants