Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix incorrect description for autoPromotionSeconds. Fixes #2000 #2525

Merged

Conversation

KipsasJaujoj
Copy link
Contributor

@KipsasJaujoj KipsasJaujoj commented Jan 19, 2023

Signed-off-by: KipsasJaujoj vaidotas.slavinskas@vinted.com

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Signed-off-by: KipsasJaujoj <vaidotas.slavinskas@vinted.com>
@sonarcloud
Copy link

sonarcloud bot commented Jan 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@KipsasJaujoj KipsasJaujoj changed the title docs: fix incorrect description for autoPromotionSeconds docs: fix incorrect description for autoPromotionSeconds. Fixed #2000 Jan 19, 2023
@KipsasJaujoj KipsasJaujoj changed the title docs: fix incorrect description for autoPromotionSeconds. Fixed #2000 docs: fix incorrect description for autoPromotionSeconds. Fixes #2000 Jan 19, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 19, 2023

Go Published Test Results

1 692 tests   1 691 ✔️  2m 13s ⏱️
   105 suites         0 💤
       1 files           1

For more details on these failures, see this check.

Results for commit 972c319.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

E2E Tests Published Test Results

    2 files      2 suites   1h 39m 22s ⏱️
  95 tests   86 ✔️ 3 💤 6
196 runs  184 ✔️ 6 💤 6

For more details on these failures, see this check.

Results for commit 972c319.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants