New rollout experiment instance starts even before the previous instance is cleaned up

[daniddelrio]

Checklist:

• I've included steps to reproduce the bug.
• I've included the version of argo rollouts.

Describe the bug

After #2633 was introduced, we set service and service.name in our Rollout Experiment to still enable the creation of a service by our experiments. We then encountered this issue:

Template 'smoketest' transitioned from Progressing -> Error: Failed to create Service service-name-smoketest for template 'smoketest': service service-name-smoketest already exists and is not owned by experiment template smoketest

It seems that the service for the Rollout experiment is being created before the previous Rollout experiment run is cleaned up, hence the service service-name-smoketest was still lying around. We deduced this from the logs:

Apr 5, 2023 @ 14:35:23.447: time="2023-04-05T12:35:23Z" level=info msg="Scaled down ReplicaSet service-name (revision 736) from 6 to 0" event_reason=ScalingReplicaSet namespace=namespace-example rollout=service-name
Apr 5, 2023 @ 14:35:23.350: time="2023-04-05T12:35:23Z" level=info msg="Created Experiment 'service-name-55cc99cd94-737-0'" event_reason=ExperimentCreated namespace=namespace-example rollout=service-name

To Reproduce

Expected behavior

Screenshots

Version

Logs

# Paste the logs from the rollout controller

# Logs for the entire controller:
kubectl logs -n argo-rollouts deployment/argo-rollouts

# Logs for a specific rollout:
kubectl logs -n argo-rollouts deployment/argo-rollouts | grep rollout=<ROLLOUTNAME

---

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.

[daniddelrio]

Update: to get it work for now, we just had to unset service.name and resort to just using service: {}

[github-actions]

This issue is stale because it has been open 60 days with no activity.