Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashboard): Refresh Rollouts dashboard UI #2723

Merged
merged 15 commits into from Apr 21, 2023

Conversation

rbreeze
Copy link
Member

@rbreeze rbreeze commented Apr 14, 2023

  • Update logo and header (matches Argo CD interface)
  • Introduce Ant Design components
  • Improved Namespace selector and layout
  • "Search" is called "Filter"
  • Improved container editing interface
  • Improved buttons and action confirmation (buttons no longer change width upon click)
  • Tooltips on Health status icons for more clarity
  • Improved layout of individual Rollout View: Steps section is much larger and can take up entire vertical area
  • Truncate the middle of long ReplicaSet names
  • Change orange outline to blue
  • Remove dependency on Argo UI V2
  • Fix Letter "L" doesn't work after navigating to a rollout details page #2273

Screenshot 2023-04-14 at 21 22 02

Screenshot 2023-04-14 at 21 21 48

Screenshot 2023-04-14 at 21 21 42

Screenshot 2023-04-14 at 21 21 31

Screenshot 2023-04-14 at 21 23 47

Screenshot 2023-04-15 at 10 26 52

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Signed-off-by: Remington Breeze <remington@breeze.software>
@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (ddce671) 81.47% compared to head (c47cf9c) 81.47%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2723   +/-   ##
=======================================
  Coverage   81.47%   81.47%           
=======================================
  Files         133      133           
  Lines       20154    20154           
=======================================
  Hits        16421    16421           
  Misses       2881     2881           
  Partials      852      852           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 14, 2023

E2E Tests Published Test Results

    4 files      4 suites   3h 33m 32s ⏱️
  96 tests   80 ✔️   5 💤 11
404 runs  366 ✔️ 20 💤 18

For more details on these failures, see this check.

Results for commit c47cf9c.

♻️ This comment has been updated with latest results.

Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
@github-actions
Copy link
Contributor

github-actions bot commented Apr 15, 2023

Go Published Test Results

1 948 tests   1 948 ✔️  2m 35s ⏱️
   118 suites         0 💤
       1 files           0

Results for commit c47cf9c.

♻️ This comment has been updated with latest results.

Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
@rbreeze rbreeze marked this pull request as ready for review April 18, 2023 17:03
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
@rbreeze rbreeze requested a review from zachaller April 21, 2023 19:35
@sonarcloud
Copy link

sonarcloud bot commented Apr 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

No Coverage information No Coverage information
5.6% 5.6% Duplication

@zachaller zachaller changed the title feat: Refresh Rollouts dashboard feat: Refresh Rollouts dashboard UI Apr 21, 2023
@zachaller zachaller changed the title feat: Refresh Rollouts dashboard UI feat(dashboard): Refresh Rollouts dashboard UI Apr 21, 2023
@zachaller zachaller merged commit 142a03a into argoproj:master Apr 21, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Letter "L" doesn't work after navigating to a rollout details page
2 participants